Page MenuHomePhabricator

Restore missing feed rendering for Maniphest points transactions
ClosedPublic

Authored by epriestley on May 25 2017, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 11:44 PM
Unknown Object (File)
Tue, Nov 26, 6:52 PM
Unknown Object (File)
Fri, Nov 22, 11:30 PM
Unknown Object (File)
Sun, Nov 17, 9:21 AM
Unknown Object (File)
Oct 26 2024, 5:47 PM
Unknown Object (File)
Oct 22 2024, 5:25 PM
Unknown Object (File)
Oct 8 2024, 4:52 AM
Unknown Object (File)
Sep 10 2024, 10:27 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T166321. These got dropped in refactoring, or maybe never existed.

Test Plan

Screen Shot 2017-05-25 at 1.03.20 PM.png (412×543 px, 56 KB)

Diff Detail

Repository
rP Phabricator
Branch
task1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17250
Build 23101: Run Core Tests
Build 23100: arc lint + arc unit

Event Timeline

Pretty sure never existed.

This revision is now accepted and ready to land.May 25 2017, 8:32 PM
This revision was automatically updated to reflect the committed changes.

T12787 shed some light on this: previously, we used shouldHideFromFeed() to hide these stories completely.

ManiphestTaskPointsTransaction faithfully ported this over, but it doesn't currently work in ModularTransactions, so the previously hidden stories became visible.

I could go either way on continuing to publish these. I'm just going to leave them for the moment (and remove the inoperative shouldHideForFeed()) but we could completely hide them again in the future if they turn out to be too noisy.