Page MenuHomePhabricator

Group query results under the "ANCESTOR" operator unconditionally
ClosedPublic

Authored by epriestley on May 24 2017, 6:51 PM.
Tags
None
Referenced Files
F15411334: D18012.diff
Wed, Mar 19, 9:00 AM
F15411060: D18012.diff
Wed, Mar 19, 8:48 AM
F15352867: D18012.diff
Mon, Mar 10, 6:52 PM
Unknown Object (File)
Feb 13 2025, 10:01 PM
Unknown Object (File)
Feb 9 2025, 4:47 AM
Unknown Object (File)
Feb 3 2025, 2:47 PM
Unknown Object (File)
Jan 29 2025, 3:21 PM
Unknown Object (File)
Jan 22 2025, 10:55 PM
Subscribers
None

Details

Summary

Fixes T12753. See that task for reproduction instructions.

We add a GROUP BY clause to queries with an "ANCESTOR" edge constraint only if the constaint has more than one PHID, but this is incorrect: the same row can be found twice by an ANCESTOR query if task T is tagged with both "B" and "C", children of "A", and the user queries for "tasks in A".

Instead, always add GROUP BY for ANCESTOR queries.

Test Plan
  • Followed test plan in T12753.
  • Saw proper paging controls after change.
  • Saw GROUP BY in DarkConsole.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable