Page MenuHomePhabricator

Group query results under the "ANCESTOR" operator unconditionally
ClosedPublic

Authored by epriestley on May 24 2017, 6:51 PM.
Tags
None
Referenced Files
F13105598: D18012.diff
Sat, Apr 27, 4:19 PM
Unknown Object (File)
Thu, Apr 25, 1:19 AM
Unknown Object (File)
Fri, Apr 19, 6:32 PM
Unknown Object (File)
Thu, Apr 11, 7:35 AM
Unknown Object (File)
Tue, Apr 9, 12:14 PM
Unknown Object (File)
Sun, Apr 7, 4:39 AM
Unknown Object (File)
Sun, Apr 7, 2:13 AM
Unknown Object (File)
Sun, Apr 7, 1:59 AM
Subscribers
None

Details

Summary

Fixes T12753. See that task for reproduction instructions.

We add a GROUP BY clause to queries with an "ANCESTOR" edge constraint only if the constaint has more than one PHID, but this is incorrect: the same row can be found twice by an ANCESTOR query if task T is tagged with both "B" and "C", children of "A", and the user queries for "tasks in A".

Instead, always add GROUP BY for ANCESTOR queries.

Test Plan
  • Followed test plan in T12753.
  • Saw proper paging controls after change.
  • Saw GROUP BY in DarkConsole.

Diff Detail

Repository
rP Phabricator
Branch
ancestor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17235
Build 23075: Run Core Tests
Build 23074: arc lint + arc unit