Page MenuHomePhabricator

Group query results under the "ANCESTOR" operator unconditionally
ClosedPublic

Authored by epriestley on May 24 2017, 6:51 PM.
Tags
None
Referenced Files
F15583096: D18012.id43330.diff
Wed, May 7, 7:50 PM
F15572375: D18012.id43323.diff
Mon, May 5, 3:18 PM
F15555738: D18012.id43330.diff
Mon, Apr 28, 12:53 PM
F15554673: D18012.id43323.diff
Mon, Apr 28, 8:00 AM
F15551629: D18012.id.diff
Sun, Apr 27, 5:45 PM
F15545055: D18012.diff
Sat, Apr 26, 8:46 AM
F15443585: D18012.diff
Mar 27 2025, 5:11 AM
F15431721: D18012.diff
Mar 24 2025, 2:05 PM
Subscribers
None

Details

Summary

Fixes T12753. See that task for reproduction instructions.

We add a GROUP BY clause to queries with an "ANCESTOR" edge constraint only if the constaint has more than one PHID, but this is incorrect: the same row can be found twice by an ANCESTOR query if task T is tagged with both "B" and "C", children of "A", and the user queries for "tasks in A".

Instead, always add GROUP BY for ANCESTOR queries.

Test Plan
  • Followed test plan in T12753.
  • Saw proper paging controls after change.
  • Saw GROUP BY in DarkConsole.

Diff Detail

Repository
rP Phabricator
Branch
ancestor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17235
Build 23075: Run Core Tests
Build 23074: arc lint + arc unit