Page MenuHomePhabricator

Group query results under the "ANCESTOR" operator unconditionally
ClosedPublic

Authored by epriestley on May 24 2017, 6:51 PM.
Tags
None
Referenced Files
F14888835: D18012.diff
Sun, Feb 9, 4:47 AM
Unknown Object (File)
Mon, Feb 3, 2:47 PM
Unknown Object (File)
Wed, Jan 29, 3:21 PM
Unknown Object (File)
Wed, Jan 22, 10:55 PM
Unknown Object (File)
Tue, Jan 21, 10:35 AM
Unknown Object (File)
Thu, Jan 16, 1:54 AM
Unknown Object (File)
Jan 6 2025, 4:33 AM
Unknown Object (File)
Dec 20 2024, 11:28 PM
Subscribers
None

Details

Summary

Fixes T12753. See that task for reproduction instructions.

We add a GROUP BY clause to queries with an "ANCESTOR" edge constraint only if the constaint has more than one PHID, but this is incorrect: the same row can be found twice by an ANCESTOR query if task T is tagged with both "B" and "C", children of "A", and the user queries for "tasks in A".

Instead, always add GROUP BY for ANCESTOR queries.

Test Plan
  • Followed test plan in T12753.
  • Saw proper paging controls after change.
  • Saw GROUP BY in DarkConsole.

Diff Detail

Repository
rP Phabricator
Branch
ancestor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17235
Build 23075: Run Core Tests
Build 23074: arc lint + arc unit