Page MenuHomePhabricator

Migrate Project workboard to modular transactions
ClosedPublic

Authored by amckinley on May 23 2017, 7:07 PM.
Tags
None
Referenced Files
F17843508: D18004.id.diff
Sun, Jul 27, 12:59 AM
F17828895: D18004.id43301.diff
Sat, Jul 26, 9:38 AM
F17819594: D18004.diff
Sat, Jul 26, 1:21 AM
F17770156: D18004.id43301.diff
Wed, Jul 23, 9:19 AM
F17748587: D18004.diff
Tue, Jul 22, 12:09 AM
F17748110: D18004.diff
Mon, Jul 21, 11:21 PM
Unknown Object (File)
Jun 18 2025, 12:14 PM
Unknown Object (File)
Jun 17 2025, 5:45 AM
Subscribers

Details

Summary

This was interesting, because there were a mix of callsites using transactions and others that just set the property on the Project object. I made everything consistent in using transactions to change this property. I also found an implementation of getTitle() that I don't think is ever being invoked since shouldHide() is returning true, but I migrated it anyway.

Test Plan

Unit tests pass + enabling/disabling workboards (and importing).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think these just didn't get converted when we swapped to transactions originally, your rewrites look correct to me.

This revision is now accepted and ready to land.May 23 2017, 7:18 PM
This revision was automatically updated to reflect the committed changes.