Page MenuHomePhabricator

Modernize Diffusion Create with sidenav, curtain
ClosedPublic

Authored by chad on May 23 2017, 5:48 PM.
Tags
None
Referenced Files
F14079483: D18003.id43299.diff
Fri, Nov 22, 8:21 AM
F14079378: D18003.diff
Fri, Nov 22, 7:56 AM
F14078700: D18003.diff
Fri, Nov 22, 4:55 AM
Unknown Object (File)
Mon, Nov 18, 3:36 PM
Unknown Object (File)
Wed, Nov 13, 7:19 PM
Unknown Object (File)
Sun, Nov 10, 1:30 AM
Unknown Object (File)
Wed, Nov 6, 3:10 PM
Unknown Object (File)
Wed, Oct 30, 2:40 PM
Subscribers

Details

Summary

This moves the navigation to a standard sidebar, and moves all actions to the curtain. Also pulled out info view when available for cleaner UI.

Test Plan

Create a git, svn, hg test repository and verify each page in the sidebar renders as expected.

image.png (1×2 px, 304 KB)

Diff Detail

Repository
rP Phabricator
Branch
manage-diffusion (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17210
Build 23036: Run Core Tests
Build 23035: arc lint + arc unit

Event Timeline

Maybe shove some of the copy/paste into the parent Panel class or whatever? Even if it's just newActionList() + newCurtanView() or whatever, I think we have enough panels that it ends up meaningfully cleaner.

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
49

(Do we need this stuff?)

This revision is now accepted and ready to land.May 23 2017, 5:52 PM
This revision was automatically updated to reflect the committed changes.