Page MenuHomePhabricator

Modernize Diffusion Create with sidenav, curtain
ClosedPublic

Authored by chad on May 23 2017, 5:48 PM.
Tags
None
Referenced Files
F16412429: D18003.diff
Mon, Jun 16, 6:00 AM
Unknown Object (File)
May 2 2025, 11:02 PM
Unknown Object (File)
Apr 15 2025, 9:55 AM
Unknown Object (File)
Apr 4 2025, 7:42 PM
Unknown Object (File)
Mar 24 2025, 3:23 PM
Unknown Object (File)
Mar 23 2025, 9:33 AM
Unknown Object (File)
Mar 23 2025, 6:41 AM
Unknown Object (File)
Mar 22 2025, 7:54 AM
Subscribers

Details

Summary

This moves the navigation to a standard sidebar, and moves all actions to the curtain. Also pulled out info view when available for cleaner UI.

Test Plan

Create a git, svn, hg test repository and verify each page in the sidebar renders as expected.

image.png (1×2 px, 304 KB)

Diff Detail

Repository
rP Phabricator
Branch
manage-diffusion (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17207
Build 23031: Run Core Tests
Build 23030: arc lint + arc unit

Event Timeline

Maybe shove some of the copy/paste into the parent Panel class or whatever? Even if it's just newActionList() + newCurtanView() or whatever, I think we have enough panels that it ends up meaningfully cleaner.

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
48

(Do we need this stuff?)

This revision is now accepted and ready to land.May 23 2017, 5:52 PM
This revision was automatically updated to reflect the committed changes.