Page MenuHomePhabricator

Modernize Diffusion Create with sidenav, curtain
ClosedPublic

Authored by chad on May 23 2017, 5:48 PM.
Tags
None
Referenced Files
F15506281: D18003.diff
Tue, Apr 15, 9:55 AM
F15470103: D18003.diff
Fri, Apr 4, 7:42 PM
F15431919: D18003.id43299.diff
Mar 24 2025, 3:23 PM
F15426545: D18003.id43298.diff
Mar 23 2025, 9:33 AM
F15425938: D18003.id43294.diff
Mar 23 2025, 6:41 AM
F15422390: D18003.id43294.diff
Mar 22 2025, 7:54 AM
F15398597: D18003.id43298.diff
Mar 17 2025, 12:48 AM
F15385624: D18003.id43298.diff
Mar 14 2025, 11:00 PM
Subscribers

Details

Summary

This moves the navigation to a standard sidebar, and moves all actions to the curtain. Also pulled out info view when available for cleaner UI.

Test Plan

Create a git, svn, hg test repository and verify each page in the sidebar renders as expected.

image.png (1×2 px, 304 KB)

Diff Detail

Repository
rP Phabricator
Branch
manage-diffusion (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17210
Build 23036: Run Core Tests
Build 23035: arc lint + arc unit

Event Timeline

Maybe shove some of the copy/paste into the parent Panel class or whatever? Even if it's just newActionList() + newCurtanView() or whatever, I think we have enough panels that it ends up meaningfully cleaner.

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
49

(Do we need this stuff?)

This revision is now accepted and ready to land.May 23 2017, 5:52 PM
This revision was automatically updated to reflect the committed changes.