Page MenuHomePhabricator

Modernize Diffusion Create with sidenav, curtain
ClosedPublic

Authored by chad on May 23 2017, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Mon, Apr 22, 8:38 PM
Unknown Object (File)
Thu, Apr 11, 9:10 AM
Unknown Object (File)
Thu, Apr 4, 6:09 PM
Unknown Object (File)
Apr 1 2024, 3:34 PM
Unknown Object (File)
Mar 21 2024, 10:55 AM
Unknown Object (File)
Jan 23 2024, 10:16 AM
Subscribers

Details

Summary

This moves the navigation to a standard sidebar, and moves all actions to the curtain. Also pulled out info view when available for cleaner UI.

Test Plan

Create a git, svn, hg test repository and verify each page in the sidebar renders as expected.

image.png (1×2 px, 304 KB)

Diff Detail

Repository
rP Phabricator
Branch
manage-diffusion (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17210
Build 23036: Run Core Tests
Build 23035: arc lint + arc unit

Event Timeline

Maybe shove some of the copy/paste into the parent Panel class or whatever? Even if it's just newActionList() + newCurtanView() or whatever, I think we have enough panels that it ends up meaningfully cleaner.

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
49

(Do we need this stuff?)

This revision is now accepted and ready to land.May 23 2017, 5:52 PM
This revision was automatically updated to reflect the committed changes.