Add sound to logged out Conpherence
ClosedPublic
Actions

Authored by chad on May 20 2017, 4:42 AM.

Tags

None

Referenced Files

	F14387113: D17973.id43230.diff
	Sat, Dec 21, 2:24 PM

	Unknown Object (File)
	Mon, Dec 16, 12:59 PM

	Unknown Object (File)
	Mon, Dec 9, 7:17 AM

	Unknown Object (File)
	Sun, Dec 8, 10:12 AM

	Unknown Object (File)
	Sat, Dec 7, 1:15 PM

	Unknown Object (File)
	Wed, Dec 4, 6:52 PM

	Unknown Object (File)
	Sat, Nov 30, 10:44 AM

	Unknown Object (File)
	Wed, Nov 27, 9:02 AM

View All 98 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12735: InvalidArgumentException when viewing a room you haven't joined from Safari

Commits

rP1d89c1ed24ae: (stable) Add sound to logged out Conpherence
rP5f49f9c793e3: Add sound to logged out Conpherence

Summary

Fixes T12735. Adds a sound if the user is logged out, skips checking a setting.

Test Plan

set participants to null and verify sound plays, no exceptions1111

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 20 2017, 4:42 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 20 2017, 4:42 AM

Harbormaster completed remote builds in B17138: Diff 43230.May 20 2017, 4:43 AM

epriestley accepted this revision.May 20 2017, 11:21 AM

This revision is now accepted and ready to land.May 20 2017, 11:21 AM

Closed by commit rP5f49f9c793e3: Add sound to logged out Conpherence (authored by chad, committed by chad). · Explain WhyMay 20 2017, 1:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

14 lines

Diff 43240

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Add sound to logged out ConpherenceClosedPublicActions