Differential D17973

Add sound to logged out Conpherence
ClosedPublic
Actions

Authored by chad on May 20 2017, 4:42 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T12735: InvalidArgumentException when viewing a room you haven't joined from Safari

Commits

rP1d89c1ed24ae: (stable) Add sound to logged out Conpherence
rP5f49f9c793e3: Add sound to logged out Conpherence

Summary

Fixes T12735. Adds a sound if the user is logged out, skips checking a setting.

Test Plan

set participants to null and verify sound plays, no exceptions1111

Diff Detail

Repository

rP Phabricator

Branch

logged-out-sounds (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17138
Build 22930: Run Core Tests
Build 22929: arc lint + arc unit

Event Timeline

chad created this revision.May 20 2017, 4:42 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 20 2017, 4:42 AM

Harbormaster completed remote builds in B17138: Diff 43230.May 20 2017, 4:43 AM

epriestley accepted this revision.May 20 2017, 11:21 AM

This revision is now accepted and ready to land.May 20 2017, 11:21 AM

Closed by commit rP5f49f9c793e3: Add sound to logged out Conpherence (authored by chad, committed by chad). · Explain WhyMay 20 2017, 1:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

14 lines

Diff 43230

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Add sound to logged out ConpherenceClosedPublicActions