Page MenuHomePhabricator

When a user cancels a new inline, clear it from the objective list
ClosedPublic

Authored by epriestley on May 20 2017, 12:35 PM.
Tags
None
Referenced Files
F15354298: D17979.diff
Tue, Mar 11, 3:13 AM
Unknown Object (File)
Wed, Feb 12, 11:14 PM
Unknown Object (File)
Feb 10 2025, 6:12 PM
Unknown Object (File)
Feb 4 2025, 10:46 PM
Unknown Object (File)
Feb 4 2025, 2:49 PM
Unknown Object (File)
Feb 3 2025, 5:30 PM
Unknown Object (File)
Jan 29 2025, 10:09 AM
Unknown Object (File)
Jan 21 2025, 12:41 PM
Subscribers
None

Details

Summary

Ref T12733. Currently, creating a new inline and then canceling it leaves a marker in the objective list. Instead, remove the marker.

Test Plan
  • Created an empty inline, cancelled. Created a non-empty inline, cancelled. No objective marker in either case.
  • Created a new normal inline, objective marker.

Diff Detail

Repository
rP Phabricator
Branch
map6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17144
Build 22942: Run Core Tests
Build 22941: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 20 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.