When a user cancels a new inline, clear it from the objective list
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 12:35 PM.

Tags

None

Referenced Files

	F18753609: D17979.id.diff
	Sat, Oct 4, 7:35 PM

	F18741494: D17979.diff
	Thu, Oct 2, 1:28 PM

	F18651869: D17979.id43236.diff
	Sun, Sep 21, 5:48 AM

	F18601848: D17979.diff
	Sat, Sep 13, 1:36 PM

	F18508841: D17979.id.diff
	Sep 5 2025, 3:03 AM

	F18501113: D17979.diff
	Sep 4 2025, 9:33 PM

	F18471699: D17979.id.diff
	Sep 2 2025, 7:33 PM

	F18457917: D17979.diff
	Sep 1 2025, 1:22 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rPaabb791c174b: (stable) When a user cancels a new inline, clear it from the objective list
rP7a40dd380ee7: When a user cancels a new inline, clear it from the objective list

Summary

Ref T12733. Currently, creating a new inline and then canceling it leaves a marker in the objective list. Instead, remove the marker.

Test Plan

Created an empty inline, cancelled. Created a non-empty inline, cancelled. No objective marker in either case.
Created a new normal inline, objective marker.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 20 2017, 12:35 PM

Harbormaster completed remote builds in B17144: Diff 43236.May 20 2017, 12:36 PM

chad accepted this revision.May 20 2017, 2:24 PM

This revision is now accepted and ready to land.May 20 2017, 2:24 PM

Closed by commit rP7a40dd380ee7: When a user cancels a new inline, clear it from the objective list (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

11 lines

Diff 43249

View Options

resources/celerity/map.php