Page MenuHomePhabricator

When a user cancels a new inline, clear it from the objective list
ClosedPublic

Authored by epriestley on May 20 2017, 12:35 PM.
Tags
None
Referenced Files
F15505640: D17979.diff
Tue, Apr 15, 4:38 AM
F15502493: D17979.id43249.diff
Mon, Apr 14, 1:32 AM
F15474761: D17979.id43236.diff
Sun, Apr 6, 12:11 PM
F15471148: D17979.id43249.diff
Sat, Apr 5, 3:38 AM
F15465459: D17979.id.diff
Wed, Apr 2, 7:01 PM
F15459598: D17979.diff
Mon, Mar 31, 2:29 PM
F15427876: D17979.id43236.diff
Sun, Mar 23, 4:36 PM
F15422016: D17979.id.diff
Sat, Mar 22, 4:38 AM
Subscribers
None

Details

Summary

Ref T12733. Currently, creating a new inline and then canceling it leaves a marker in the objective list. Instead, remove the marker.

Test Plan
  • Created an empty inline, cancelled. Created a non-empty inline, cancelled. No objective marker in either case.
  • Created a new normal inline, objective marker.

Diff Detail

Repository
rP Phabricator
Branch
map6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17144
Build 22942: Run Core Tests
Build 22941: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 20 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.