Page MenuHomePhabricator

When a user cancels a new inline, clear it from the objective list
ClosedPublic

Authored by epriestley on May 20 2017, 12:35 PM.
Tags
None
Referenced Files
F19154217: D17979.diff
Thu, Dec 11, 1:53 PM
F19099358: D17979.id.diff
Thu, Dec 4, 7:47 PM
F19091038: D17979.diff
Wed, Dec 3, 1:22 PM
F19016237: D17979.id.diff
Sun, Nov 23, 3:12 AM
F18803199: D17979.id43249.diff
Oct 17 2025, 10:03 PM
F18753609: D17979.id.diff
Oct 4 2025, 7:35 PM
F18741494: D17979.diff
Oct 2 2025, 1:28 PM
F18651869: D17979.id43236.diff
Sep 21 2025, 5:48 AM
Subscribers
None

Details

Summary

Ref T12733. Currently, creating a new inline and then canceling it leaves a marker in the objective list. Instead, remove the marker.

Test Plan
  • Created an empty inline, cancelled. Created a non-empty inline, cancelled. No objective marker in either case.
  • Created a new normal inline, objective marker.

Diff Detail

Repository
rP Phabricator
Branch
map6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17144
Build 22942: Run Core Tests
Build 22941: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 20 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.