Page MenuHomePhabricator

Restore "h" to hide or show files, and modernize file visibility toggling
ClosedPublic

Authored by epriestley on May 17 2017, 7:54 PM.
Tags
None
Referenced Files
F13229697: D17940.id43150.diff
Mon, May 20, 6:31 PM
F13215710: D17940.id43148.diff
Fri, May 17, 7:19 PM
F13203886: D17940.diff
Wed, May 15, 12:11 AM
F13186509: D17940.diff
Sat, May 11, 3:40 AM
Unknown Object (File)
Tue, May 7, 6:57 AM
Unknown Object (File)
Fri, May 3, 8:24 PM
Unknown Object (File)
Fri, May 3, 4:51 AM
Unknown Object (File)
Thu, Apr 25, 12:40 AM
Subscribers
None

Details

Summary

Ref T12616. This puts "h" back to collapse or expand the current file.

This removes some very complicated/messy code around following links in the table of contents and getting files auto-expanded. I suspect no one will miss this, but we can restore it if ayone notices.

Test Plan

Pressed "h" to collapse/expand a file. Also used the menu items.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

webroot/rsrc/css/application/differential/changeset-view.css
328

This at least makes the weird collapsed state a little less weird/goofy looking (see T12688).

webroot/rsrc/js/application/diff/DiffChangesetList.js
369–386

Oops, some copy-paste slipup nonsense here, one sec.

  • Copy/paste with greater finesse.
This revision is now accepted and ready to land.May 18 2017, 3:02 PM
This revision was automatically updated to reflect the committed changes.