Page MenuHomePhabricator

Restore "h" to hide or show files, and modernize file visibility toggling
ClosedPublic

Authored by epriestley on May 17 2017, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 2:11 PM
Unknown Object (File)
Tue, Mar 12, 5:38 AM
Unknown Object (File)
Feb 16 2024, 9:13 PM
Unknown Object (File)
Jan 16 2024, 5:03 PM
Unknown Object (File)
Dec 27 2023, 11:06 AM
Unknown Object (File)
Dec 27 2023, 11:05 AM
Unknown Object (File)
Dec 27 2023, 11:05 AM
Unknown Object (File)
Dec 27 2023, 11:05 AM
Subscribers
None

Details

Summary

Ref T12616. This puts "h" back to collapse or expand the current file.

This removes some very complicated/messy code around following links in the table of contents and getting files auto-expanded. I suspect no one will miss this, but we can restore it if ayone notices.

Test Plan

Pressed "h" to collapse/expand a file. Also used the menu items.

Diff Detail

Repository
rP Phabricator
Branch
inline24
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17069
Build 22826: Run Core Tests
Build 22825: arc lint + arc unit

Event Timeline

webroot/rsrc/css/application/differential/changeset-view.css
328

This at least makes the weird collapsed state a little less weird/goofy looking (see T12688).

webroot/rsrc/js/application/diff/DiffChangesetList.js
369–386

Oops, some copy-paste slipup nonsense here, one sec.

  • Copy/paste with greater finesse.
This revision is now accepted and ready to land.May 18 2017, 3:02 PM
This revision was automatically updated to reflect the committed changes.