Page MenuHomePhabricator

In Differential, allow "r" to create comments and "R" to quote
ClosedPublic

Authored by epriestley on May 16 2017, 11:56 PM.
Tags
None
Referenced Files
F15465389: D17920.id43108.diff
Wed, Apr 2, 6:06 PM
F15464502: D17920.id43106.diff
Wed, Apr 2, 10:06 AM
F15463841: D17920.id.diff
Wed, Apr 2, 3:59 AM
F15460106: D17920.diff
Mon, Mar 31, 8:10 PM
F15409948: D17920.diff
Wed, Mar 19, 6:04 AM
Unknown Object (File)
Feb 20 2025, 7:49 PM
Unknown Object (File)
Feb 20 2025, 3:34 AM
Unknown Object (File)
Jan 31 2025, 1:15 PM
Subscribers
None

Details

Summary

Ref T11401. Fixes T5232. Ref T12616.

Partly, this moves more code over to the new stuff.

This also allows "r" to work if you have code selected (not just comments). If you "reply" to code, you start a new comment.

You can "R" a comment to quote it. This just starts a new comment normally if you "R" a block of code. This is sort of a power-user version of "quote" since it seems like it probably doesn't really make sense to put it in the UI ever (maybe).

With the new click-to-select, you can click + "R" to reply-with-quote.

Test Plan

Used "r" and "R" to reply to comments and code.

Diff Detail

Repository
rP Phabricator
Branch
inline16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17034
Build 22779: Run Core Tests
Build 22778: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 17 2017, 12:13 AM
This revision was automatically updated to reflect the committed changes.