Resize the Differential keyboard focus reticle when the window is resized
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 1:54 PM.

Tags

None

Referenced Files

	F15569696: D17901.id43060.diff
	Sun, May 4, 3:41 AM

	F15539312: D17901.diff
	Fri, Apr 25, 12:46 AM

	F15537914: D17901.id43060.diff
	Thu, Apr 24, 4:35 PM

	F15533808: D17901.id43060.diff
	Wed, Apr 23, 10:08 PM

	F15530863: D17901.id43060.diff
	Wed, Apr 23, 7:32 AM

	F15530239: D17901.id43071.diff
	Wed, Apr 23, 3:02 AM

	F15529045: D17901.id.diff
	Tue, Apr 22, 4:17 PM

	F15528808: D17901.id43065.diff
	Tue, Apr 22, 2:09 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12632: Resizing a diff does not resize the keyboard focus reticle
T12634: Keyboard focus reticle is generally oblivious to the world around it

Commits

rP7d6133929a66: Resize the Differential keyboard focus reticle when the window is resized

Summary

Fixes T12632. Ref T12634. Currently, the keyboard focus reticle does not redraw properly after a window resize.

Test Plan

Used "n" to select a block.
Resized the window.
Saw the reticle also resize properly.

Diff Detail

Repository

rP Phabricator

Branch

focus3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16993
Build 22718: Run Core Tests
Build 22717: arc lint + arc unit

Event Timeline

epriestley created this revision.May 16 2017, 1:54 PM

Harbormaster failed remote builds in B16988: Diff 43060!May 16 2017, 1:55 PM

Rebuild celerity map.

Harbormaster completed remote builds in B16993: Diff 43065.May 16 2017, 2:15 PM

chad accepted this revision.May 16 2017, 2:22 PM

This revision is now accepted and ready to land.May 16 2017, 2:22 PM

Closed by commit rP7d6133929a66: Resize the Differential keyboard focus reticle when the window is resized (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

7 lines

Diff 43065

View Options

resources/celerity/map.php