Page MenuHomePhabricator

Resize the Differential keyboard focus reticle when the window is resized
ClosedPublic

Authored by epriestley on May 16 2017, 1:54 PM.
Tags
None
Referenced Files
F18814737: D17901.id43065.diff
Mon, Oct 20, 11:51 PM
F18812293: D17901.id43071.diff
Mon, Oct 20, 8:17 AM
F18753548: D17901.id43071.diff
Sat, Oct 4, 7:25 PM
F18749924: D17901.id.diff
Sat, Oct 4, 5:43 AM
F18705673: D17901.id43065.diff
Sun, Sep 28, 12:29 PM
F18593734: D17901.diff
Sep 12 2025, 3:47 PM
F18593732: D17901.diff
Sep 12 2025, 3:47 PM
F18508801: D17901.id.diff
Sep 5 2025, 3:02 AM
Subscribers
None

Details

Summary

Fixes T12632. Ref T12634. Currently, the keyboard focus reticle does not redraw properly after a window resize.

Test Plan
  • Used "n" to select a block.
  • Resized the window.
  • Saw the reticle also resize properly.

Diff Detail

Repository
rP Phabricator
Branch
focus3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16988
Build 22709: Run Core Tests
Build 22708: arc lint + arc unit

Unit TestsFailed

TimeTest
263 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
2 assertions passed.
1 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
1 assertion passed.
View Full Test Results (1 Failed · 337 Passed)