Page MenuHomePhabricator

Mostly move inline editing to DiffInline
ClosedPublic

Authored by epriestley on May 15 2017, 7:53 PM.
Tags
None
Referenced Files
F15407252: D17887.diff
Tue, Mar 18, 4:32 PM
Unknown Object (File)
Fri, Feb 28, 4:58 AM
Unknown Object (File)
Feb 1 2025, 4:37 PM
Unknown Object (File)
Jan 25 2025, 7:45 AM
Unknown Object (File)
Jan 24 2025, 9:52 PM
Unknown Object (File)
Jan 2 2025, 2:30 AM
Unknown Object (File)
Jan 2 2025, 12:35 AM
Unknown Object (File)
Dec 26 2024, 8:14 AM
Subscribers
None

Details

Summary

Ref T12616. This doesn't pull over everything (some UI feedback didn't make it yet, and you can't cancel + undo cancelling edits yet) but editing comments technically works.

This is a little shaky, but feels less shaky than every other approach I've tried, so I think I'm finally on a reasonable track here.

Test Plan

Edited some inline comments.

Diff Detail

Repository
rP Phabricator
Branch
inline8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16953
Build 22657: Run Core Tests
Build 22656: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 15 2017, 10:52 PM
This revision was automatically updated to reflect the committed changes.