Page MenuHomePhabricator

Mostly move inline editing to DiffInline
ClosedPublic

Authored by epriestley on May 15 2017, 7:53 PM.
Tags
None
Referenced Files
F19488161: D17887.diff
Thu, Jan 8, 4:47 AM
F18849590: D17887.id43050.diff
Oct 30 2025, 10:49 AM
F18831629: D17887.diff
Oct 25 2025, 1:50 PM
F18802996: D17887.id43026.diff
Oct 17 2025, 9:11 PM
F18683667: D17887.diff
Sep 26 2025, 8:02 AM
F18644445: D17887.diff
Sep 19 2025, 5:19 AM
F18587679: D17887.diff
Sep 11 2025, 10:04 PM
F18508789: D17887.id.diff
Sep 5 2025, 3:01 AM
Subscribers
None

Details

Summary

Ref T12616. This doesn't pull over everything (some UI feedback didn't make it yet, and you can't cancel + undo cancelling edits yet) but editing comments technically works.

This is a little shaky, but feels less shaky than every other approach I've tried, so I think I'm finally on a reasonable track here.

Test Plan

Edited some inline comments.

Diff Detail

Repository
rP Phabricator
Branch
inline8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16953
Build 22657: Run Core Tests
Build 22656: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 15 2017, 10:52 PM
This revision was automatically updated to reflect the committed changes.