Fixes T12679. Reproduction steps appear to be:
- As a logged-out user, view revision list or commit list.
- Enable bucketing by action required.
- Before patch: foreach (null as ...) causes error spew.
- After patch: foreach (array() as ...) works great.
Details
Details
- Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits).
- After patches, no more errors in the log.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- list1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16909 Build 22593: Run Core Tests Build 22592: arc lint + arc unit