Page MenuHomePhabricator
Differential D17855

Update Fund for EditEngine
ClosedPublic
Actions

Authored by chad on May 9 2017, 2:35 AM.
Tags
None
Referenced Files
F13197847: D17855.id42947.diff
Mon, May 13, 1:23 AM
F13185104: D17855.diff
Sat, May 11, 2:36 AM
F13184642: D17855.id42944.diff
Fri, May 10, 9:32 PM
F13184347: D17855.id.diff
Fri, May 10, 5:56 PM
Unknown Object (File)
Tue, May 7, 5:00 AM
Unknown Object (File)
Fri, May 3, 2:21 AM
Unknown Object (File)
Mon, Apr 29, 1:47 PM
Unknown Object (File)
Sun, Apr 28, 5:48 PM
View All 82 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12685: Modular Transactions Migrations Errata
Commits
rP86f9318052c3: Update Fund for EditEngine
Summary

Ref T12685, updates fund for edit engine.

Test Plan

Create a Fund, Edit a Fund, wipe out Merchants, check errors for name and missing merchants, back Fund.

Diff Detail

Repository
rP Phabricator
Branch
fund-edit-engine (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16870
Build 22527: Run Core Tests
Build 22526: arc lint + arc unit

Event Timeline

chad created this revision.May 9 2017, 2:35 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 9 2017, 2:35 AM
Harbormaster completed remote builds in B16870: Diff 42944.May 9 2017, 2:35 AM
Harbormaster completed remote builds in B16870: Diff 42944.
epriestley edited edge metadata.May 9 2017, 4:14 AM

(This looks right, but let me give it a more detailed look in the morning.)

epriestley accepted this revision.May 9 2017, 3:03 PM
This revision is now accepted and ready to land.May 9 2017, 3:03 PM
chad added a comment.May 9 2017, 3:45 PM

believe it or not this fixes bugs instead of implementing them!

Closed by commit rP86f9318052c3: Update Fund for EditEngine (authored by chad, committed by chad). · Explain WhyMay 9 2017, 3:46 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D17857: Update Fund for EditEngine commenting.May 9 2017, 4:04 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
fund/
application/
3 lines
controller/
255 lines
editor/
152 lines
storage/
4 lines

Diff 42944

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/fund/application/PhabricatorFundApplication.php

Loading...
View Options

src/applications/fund/controller/FundInitiativeEditController.php

Loading...
View Options

src/applications/fund/editor/FundInitiativeEditEngine.php

Loading...
View Options

src/applications/fund/storage/FundInitiative.php

Loading...
Phabricator · Built by Phacility