Use grey dots for disabled users, even if a user is also unverified
ClosedPublic
Actions

Authored by epriestley on Apr 30 2017, 7:58 PM.

Tags

None

Referenced Files

	F15380505: D17806.diff
	Mar 14 2025, 3:23 AM

	F15333079: D17806.diff
	Mar 7 2025, 11:44 PM

	Unknown Object (File)
	Feb 14 2025, 4:21 PM

	Unknown Object (File)
	Feb 9 2025, 3:56 AM

	Unknown Object (File)
	Feb 9 2025, 3:56 AM

	Unknown Object (File)
	Feb 9 2025, 3:56 AM

	Unknown Object (File)
	Feb 9 2025, 3:56 AM

	Unknown Object (File)
	Jan 29 2025, 7:44 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled")

Commits

rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified

Summary

Fixes T12559.

Test Plan

Screen Shot 2017-04-30 at 12.56.55 PM.png (141×334 px, 11 KB)

Screen Shot 2017-04-30 at 12.55.51 PM.png (171×295 px, 12 KB)

Screen Shot 2017-04-30 at 12.57.19 PM.png (129×454 px, 16 KB)

Diff Detail

Repository

rP Phabricator

Branch

purple

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16743
Build 22335: Run Core Tests
Build 22334: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2017, 7:58 PM

Harbormaster completed remote builds in B16743: Diff 42816.Apr 30 2017, 7:59 PM

chad accepted this revision.Apr 30 2017, 7:59 PM

This revision is now accepted and ready to land.Apr 30 2017, 7:59 PM

Closed by commit rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified (authored by epriestley, committed by epriestley). · Explain WhyApr 30 2017, 8:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

markup/

PhabricatorMentionRemarkupRule.php

4 lines

phid/

PhabricatorPeopleUserPHIDType.php

4 lines

Diff 42816

View Options

src/applications/people/markup/PhabricatorMentionRemarkupRule.php