Use grey dots for disabled users, even if a user is also unverified
ClosedPublic
Actions

Authored by epriestley on Apr 30 2017, 7:58 PM.

Tags

None

Referenced Files

	F17739421: D17806.diff
	Mon, Jul 21, 2:40 AM

	F17727279: D17806.id42816.diff
	Sat, Jul 19, 1:53 AM

	F17724329: D17806.id.diff
	Fri, Jul 18, 12:43 PM

	F17713477: D17806.diff
	Thu, Jul 17, 2:01 PM

	Unknown Object (File)
	Apr 26 2025, 6:27 PM

	Unknown Object (File)
	Apr 26 2025, 4:41 PM

	Unknown Object (File)
	Apr 26 2025, 5:58 AM

	Unknown Object (File)
	Apr 25 2025, 6:23 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12559: Purple user dot ("Unapproved") has higher display priority than grey dot ("Disabled")

Commits

rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified

Summary

Fixes T12559.

Test Plan

Screen Shot 2017-04-30 at 12.56.55 PM.png (141×334 px, 11 KB)

Screen Shot 2017-04-30 at 12.55.51 PM.png (171×295 px, 12 KB)

Screen Shot 2017-04-30 at 12.57.19 PM.png (129×454 px, 16 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 30 2017, 7:58 PM

Harbormaster completed remote builds in B16743: Diff 42816.Apr 30 2017, 7:59 PM

chad accepted this revision.Apr 30 2017, 7:59 PM

This revision is now accepted and ready to land.Apr 30 2017, 7:59 PM

Closed by commit rP89d0c8e388fb: Use grey dots for disabled users, even if a user is also unverified (authored by epriestley, committed by epriestley). · Explain WhyApr 30 2017, 8:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

markup/

PhabricatorMentionRemarkupRule.php

4 lines

phid/

PhabricatorPeopleUserPHIDType.php

4 lines

Diff 42817

View Options

src/applications/people/markup/PhabricatorMentionRemarkupRule.php