Page MenuHomePhabricator

Only recognize "Fixes ..." in main revision content like the Summary or Test Plan
ClosedPublic

Authored by epriestley on Apr 30 2017, 7:48 PM.
Tags
None
Referenced Files
F14025066: D17805.diff
Thu, Nov 7, 2:14 PM
F14003232: D17805.id42818.diff
Sat, Oct 26, 3:40 AM
F13980702: D17805.id42815.diff
Sat, Oct 19, 12:10 PM
F13967024: D17805.diff
Wed, Oct 16, 11:06 AM
Unknown Object (File)
Oct 2 2024, 12:06 AM
Unknown Object (File)
Sep 20 2024, 12:32 PM
Unknown Object (File)
Sep 20 2024, 9:41 AM
Unknown Object (File)
Sep 1 2024, 5:19 AM
Subscribers
None

Details

Summary

Fixes T12642. Currently, writing "Fixes T..." in a comment gets picked up as a formal "fixes".

This is a bit confusing, and can also give you a "no effect" error if you "fixes ..." a task which is already "fixes"'d.

We could make the duplicate action a non-error, but just prevent the text from having an effect instead, which seems cleaner.

Test Plan
  • Wrote "Fixes ..." in a summary, saw a "fixes" relationship established.
  • Wrote "Fixes ..." in a comment, got a "mention" instead.
  • var_dump()'d some stuff as a sanity check, looked reasonable.

Diff Detail

Repository
rP Phabricator
Branch
comment1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16742
Build 22333: Run Core Tests
Build 22332: arc lint + arc unit