Page MenuHomePhabricator

Only recognize "Fixes ..." in main revision content like the Summary or Test Plan
ClosedPublic

Authored by epriestley on Apr 30 2017, 7:48 PM.
Tags
None
Referenced Files
F19092880: D17805.diff
Wed, Dec 3, 6:57 PM
F19057297: D17805.id42815.diff
Fri, Nov 28, 9:55 PM
F19057296: D17805.id.diff
Fri, Nov 28, 9:55 PM
F19056767: D17805.id42818.diff
Fri, Nov 28, 8:40 PM
F19038818: D17805.id.diff
Wed, Nov 26, 5:45 AM
F19032306: D17805.diff
Tue, Nov 25, 5:55 AM
F18837661: D17805.diff
Oct 27 2025, 7:14 AM
F18807126: D17805.diff
Oct 18 2025, 11:20 PM
Subscribers
None

Details

Summary

Fixes T12642. Currently, writing "Fixes T..." in a comment gets picked up as a formal "fixes".

This is a bit confusing, and can also give you a "no effect" error if you "fixes ..." a task which is already "fixes"'d.

We could make the duplicate action a non-error, but just prevent the text from having an effect instead, which seems cleaner.

Test Plan
  • Wrote "Fixes ..." in a summary, saw a "fixes" relationship established.
  • Wrote "Fixes ..." in a comment, got a "mention" instead.
  • var_dump()'d some stuff as a sanity check, looked reasonable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable