Page MenuHomePhabricator

Fix autocomplete/send-on-enter interactions
ClosedPublic

Authored by epriestley on Apr 26 2017, 3:44 PM.
Tags
None
Referenced Files
F14643531: D17794.id42788.diff
Sat, Jan 11, 8:22 AM
F14642139: D17794.diff
Sat, Jan 11, 5:20 AM
Unknown Object (File)
Thu, Jan 2, 9:49 AM
Unknown Object (File)
Mon, Dec 30, 12:07 AM
Unknown Object (File)
Fri, Dec 27, 8:31 PM
Unknown Object (File)
Thu, Dec 19, 9:48 AM
Unknown Object (File)
Dec 1 2024, 6:26 AM
Unknown Object (File)
Nov 28 2024, 6:36 AM
Subscribers

Details

Summary

Send-on-enter and autocomplete both listen for "return" keypresses, and could race. Have autocomplete let other handlers take a shot at the action before it does.

Also, fix a case where ":)" and the suffix list (which lets you type someone is 100% to blame here (@epriestley) and get the results you want) interacted badly, so ":)" cancels the autocompleter like ":3" does.

Test Plan
  • Typed "@xxx" and mashed return real fast over and over again while reloading the page. Before: sometimes handlers raced and text submitted. After: always handled by autocomplete behavior.
  • Typed ":", ")", "<return>", sent an emoticon (previously: no).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable