Page MenuHomePhabricator

Fix autocomplete/send-on-enter interactions
ClosedPublic

Authored by epriestley on Apr 26 2017, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 1:06 AM
Unknown Object (File)
Sun, Apr 21, 6:27 PM
Unknown Object (File)
Thu, Apr 11, 10:55 AM
Unknown Object (File)
Apr 1 2024, 2:16 AM
Unknown Object (File)
Mar 29 2024, 1:22 PM
Unknown Object (File)
Mar 18 2024, 5:44 AM
Unknown Object (File)
Jan 22 2024, 4:45 PM
Unknown Object (File)
Jan 18 2024, 4:33 PM
Subscribers

Details

Summary

Send-on-enter and autocomplete both listen for "return" keypresses, and could race. Have autocomplete let other handlers take a shot at the action before it does.

Also, fix a case where ":)" and the suffix list (which lets you type someone is 100% to blame here (@epriestley) and get the results you want) interacted badly, so ":)" cancels the autocompleter like ":3" does.

Test Plan
  • Typed "@xxx" and mashed return real fast over and over again while reloading the page. Before: sometimes handlers raced and text submitted. After: always handled by autocomplete behavior.
  • Typed ":", ")", "<return>", sent an emoticon (previously: no).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable