Page MenuHomePhabricator

Fix autocomplete/send-on-enter interactions
ClosedPublic

Authored by epriestley on Apr 26 2017, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 7:52 PM
Unknown Object (File)
Sat, Jan 25, 1:31 PM
Unknown Object (File)
Thu, Jan 23, 1:14 PM
Unknown Object (File)
Tue, Jan 21, 10:24 AM
Unknown Object (File)
Sun, Jan 12, 8:07 AM
Unknown Object (File)
Sun, Jan 12, 7:34 AM
Unknown Object (File)
Sat, Jan 11, 8:22 AM
Unknown Object (File)
Sat, Jan 11, 5:20 AM
Subscribers

Details

Summary

Send-on-enter and autocomplete both listen for "return" keypresses, and could race. Have autocomplete let other handlers take a shot at the action before it does.

Also, fix a case where ":)" and the suffix list (which lets you type someone is 100% to blame here (@epriestley) and get the results you want) interacted badly, so ":)" cancels the autocompleter like ":3" does.

Test Plan
  • Typed "@xxx" and mashed return real fast over and over again while reloading the page. Before: sometimes handlers raced and text submitted. After: always handled by autocomplete behavior.
  • Typed ":", ")", "<return>", sent an emoticon (previously: no).

Diff Detail

Repository
rP Phabricator
Branch
auto1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16713
Build 22296: Run Core Tests
Build 22295: arc lint + arc unit