Page MenuHomePhabricator

Attach Diffusion Pagers to their ObjectBoxView
ClosedPublic

Authored by chad on Apr 21 2017, 6:16 PM.
Tags
None
Referenced Files
F15428992: D17754.id42703.diff
Sun, Mar 23, 11:58 PM
F15425668: D17754.diff
Sun, Mar 23, 5:21 AM
Unknown Object (File)
Feb 18 2025, 4:50 PM
Unknown Object (File)
Feb 15 2025, 4:32 AM
Unknown Object (File)
Feb 14 2025, 4:44 PM
Unknown Object (File)
Feb 9 2025, 12:19 PM
Unknown Object (File)
Feb 8 2025, 9:05 PM
Unknown Object (File)
Jan 10 2025, 11:19 PM
Subscribers

Details

Summary

Adds the ability to set a pager onto an object box directly and pick up appropriate styles.

Test Plan

grep for renderTablePagerBox, test layouts with and without a pager.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 21 2017, 6:16 PM

btw, how can I increase the layout here, seems to cut off at 100 and I couldn't find a constant for it.

src/applications/diffusion/controller/DiffusionCommitController.php
5 ↗(On Diff #42702)

whoopsies.

It's a builtin Conduit limit so there's no way to increase it without far-reaching effects.

That's probably a lie in practice but it's true in theory!

This revision was automatically updated to reflect the committed changes.