Page MenuHomePhabricator

Attach Diffusion Pagers to their ObjectBoxView
ClosedPublic

Authored by chad on Apr 21 2017, 6:16 PM.
Tags
None
Referenced Files
F14076616: D17754.diff
Thu, Nov 21, 6:52 PM
Unknown Object (File)
Mon, Oct 28, 5:00 AM
Unknown Object (File)
Oct 8 2024, 9:27 AM
Unknown Object (File)
Oct 1 2024, 12:17 PM
Unknown Object (File)
Sep 25 2024, 2:02 PM
Unknown Object (File)
Sep 6 2024, 12:04 AM
Unknown Object (File)
Sep 5 2024, 6:17 AM
Unknown Object (File)
Aug 31 2024, 11:56 AM
Subscribers

Details

Summary

Adds the ability to set a pager onto an object box directly and pick up appropriate styles.

Test Plan

grep for renderTablePagerBox, test layouts with and without a pager.

Diff Detail

Repository
rP Phabricator
Branch
diffusion-pager (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16630
Build 22176: Run Core Tests
Build 22175: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 21 2017, 6:16 PM

btw, how can I increase the layout here, seems to cut off at 100 and I couldn't find a constant for it.

src/applications/diffusion/controller/DiffusionCommitController.php
5

whoopsies.

It's a builtin Conduit limit so there's no way to increase it without far-reaching effects.

That's probably a lie in practice but it's true in theory!

This revision was automatically updated to reflect the committed changes.