Page MenuHomePhabricator

Attach Diffusion Pagers to their ObjectBoxView
ClosedPublic

Authored by chad on Apr 21 2017, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 12:55 PM
Unknown Object (File)
Sat, Dec 14, 4:18 PM
Unknown Object (File)
Fri, Dec 13, 4:30 AM
Unknown Object (File)
Sun, Dec 8, 12:16 PM
Unknown Object (File)
Fri, Dec 6, 11:46 AM
Unknown Object (File)
Nov 22 2024, 12:08 AM
Unknown Object (File)
Nov 21 2024, 6:52 PM
Unknown Object (File)
Oct 28 2024, 5:00 AM
Subscribers

Details

Summary

Adds the ability to set a pager onto an object box directly and pick up appropriate styles.

Test Plan

grep for renderTablePagerBox, test layouts with and without a pager.

Diff Detail

Repository
rP Phabricator
Branch
diffusion-pager (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16630
Build 22176: Run Core Tests
Build 22175: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 21 2017, 6:16 PM

btw, how can I increase the layout here, seems to cut off at 100 and I couldn't find a constant for it.

src/applications/diffusion/controller/DiffusionCommitController.php
5

whoopsies.

It's a builtin Conduit limit so there's no way to increase it without far-reaching effects.

That's probably a lie in practice but it's true in theory!

This revision was automatically updated to reflect the committed changes.