Page MenuHomePhabricator

In Conpherence, stop throwing away stuff users have typed when a reply arrives
ClosedPublic

Authored by epriestley on Apr 20 2017, 12:07 AM.
Tags
None
Referenced Files
F15394899: D17742.diff
Sun, Mar 16, 2:24 AM
F15334192: D17742.id42675.diff
Sat, Mar 8, 7:25 AM
F15331654: D17742.diff
Fri, Mar 7, 12:25 PM
F15302632: D17742.id.diff
Wed, Mar 5, 7:08 PM
F15299728: D17742.id42675.diff
Wed, Mar 5, 3:56 PM
Unknown Object (File)
Mon, Feb 24, 5:12 PM
Unknown Object (File)
Feb 3 2025, 2:56 PM
Unknown Object (File)
Jan 31 2025, 3:40 AM
Subscribers
None

Details

Summary

Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

  • Add a sleep(3) to UpdateController.
  • Type "AAA".
  • Press enter.
  • Real fast, type "BBB".
  • When the "AAA" arrives, your "BBB" is lost. Sad!
Test Plan
  • Did the thing described above; no longer lost "BBB".
  • Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable