Page MenuHomePhabricator

In Conpherence, stop throwing away stuff users have typed when a reply arrives
ClosedPublic

Authored by epriestley on Apr 20 2017, 12:07 AM.
Tags
None
Referenced Files
F13097150: D17742.diff
Thu, Apr 25, 9:19 PM
F13096262: D17742.id42675.diff
Thu, Apr 25, 3:43 PM
Unknown Object (File)
Thu, Apr 25, 2:38 AM
Unknown Object (File)
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Fri, Apr 19, 6:25 PM
Unknown Object (File)
Fri, Apr 19, 2:57 PM
Unknown Object (File)
Thu, Apr 11, 9:55 AM
Unknown Object (File)
Sat, Apr 6, 8:11 AM
Subscribers
None

Details

Summary

Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

  • Add a sleep(3) to UpdateController.
  • Type "AAA".
  • Press enter.
  • Real fast, type "BBB".
  • When the "AAA" arrives, your "BBB" is lost. Sad!
Test Plan
  • Did the thing described above; no longer lost "BBB".
  • Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable