Page MenuHomePhabricator

In Conpherence, stop throwing away stuff users have typed when a reply arrives
ClosedPublic

Authored by epriestley on Apr 20 2017, 12:07 AM.
Tags
None
Referenced Files
F14090742: D17742.diff
Sun, Nov 24, 8:01 PM
Unknown Object (File)
Thu, Nov 21, 7:01 PM
Unknown Object (File)
Thu, Nov 21, 6:38 AM
Unknown Object (File)
Mon, Nov 18, 10:09 AM
Unknown Object (File)
Sun, Nov 17, 2:03 AM
Unknown Object (File)
Thu, Nov 14, 6:23 AM
Unknown Object (File)
Tue, Nov 12, 2:45 AM
Unknown Object (File)
Sun, Nov 10, 10:27 AM
Subscribers
None

Details

Summary

Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

  • Add a sleep(3) to UpdateController.
  • Type "AAA".
  • Press enter.
  • Real fast, type "BBB".
  • When the "AAA" arrives, your "BBB" is lost. Sad!
Test Plan
  • Did the thing described above; no longer lost "BBB".
  • Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable