Page MenuHomePhabricator

In Conpherence, stop throwing away stuff users have typed when a reply arrives
ClosedPublic

Authored by epriestley on Apr 20 2017, 12:07 AM.
Tags
None
Referenced Files
F19322782: D17742.diff
Thu, Dec 25, 11:31 AM
F19025882: D17742.id.diff
Nov 24 2025, 9:05 AM
F19017592: D17742.diff
Nov 23 2025, 8:25 AM
F18903815: D17742.id42675.diff
Nov 8 2025, 6:25 AM
F18871570: D17742.id42685.diff
Nov 4 2025, 11:27 PM
F18852353: D17742.id42675.diff
Oct 31 2025, 8:06 AM
F18817115: D17742.diff
Oct 21 2025, 12:34 PM
F18816224: D17742.id.diff
Oct 21 2025, 5:31 AM
Subscribers
None

Details

Summary

Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

  • Add a sleep(3) to UpdateController.
  • Type "AAA".
  • Press enter.
  • Real fast, type "BBB".
  • When the "AAA" arrives, your "BBB" is lost. Sad!
Test Plan
  • Did the thing described above; no longer lost "BBB".
  • Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Diff Detail

Repository
rP Phabricator
Branch
update1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16610
Build 22149: Run Core Tests
Build 22148: arc lint + arc unit