Page MenuHomePhabricator

Make "Range" HTTP header work for Celerity static resource requests
ClosedPublic

Authored by epriestley on Apr 18 2017, 8:27 PM.
Tags
None
Referenced Files
F15409555: D17724.id42629.diff
Wed, Mar 19, 4:41 AM
F15393935: D17724.id42629.diff
Sat, Mar 15, 11:17 PM
F15377295: D17724.id42629.diff
Thu, Mar 13, 8:33 AM
F15334141: D17724.id42629.diff
Sat, Mar 8, 7:03 AM
Unknown Object (File)
Sat, Feb 22, 12:10 AM
Unknown Object (File)
Feb 10 2025, 8:26 PM
Unknown Object (File)
Feb 8 2025, 11:55 PM
Unknown Object (File)
Feb 7 2025, 4:35 AM
Subscribers
None

Details

Summary

Ref T7567. In T8266 I fixed a bunch of obscure "Range" issues, but only for file downloads -- not for Celerity.

Extend all that stuff to Celerity, which is fortunately much easier.

I believe this will fix Conpherence sounds in Safari.

Test Plan
  • Wrote out an HTTP request in a text file with Range: bytes=0-1 and similar, piped it to localhost with cat request.txt | nc localhost 80, saw server return appropriate range responses consistent with file behavior after T8266, which all seems to work.
  • Also did that for files to try to make sure I wasn't breaking anything.

Diff Detail

Repository
rP Phabricator
Branch
range1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16563
Build 22075: Run Core Tests
Build 22074: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 18 2017, 8:45 PM
This revision was automatically updated to reflect the committed changes.