Paths

Table of Contentst

Differential D17700

Fix a bad variable in global typehaead order/limit code
ClosedPublic
Actions

Authored by epriestley on Apr 17 2017, 2:34 PM.

Details

Reviewers

chad

Maniphest Tasks

T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name

Commits

rPab3c81039c2f: (stable) Fix a bad variable in global typehaead order/limit code
rPb08b4cf0b5ff: Fix a bad variable in global typehaead order/limit code

Summary

Ref T12538. I missed this in D17695, which renamed the variable. The logic was also a little off since jj is an index, not a count.

Test Plan

Typed con in global search, which hits "Con-pherence", "Con-duit" and "Con-fig", plus a bunch of other stuff. Got results after patch.

Diff Detail

Repository

rP Phabricator

Branch

type1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16502
Build 21980: Run Core Tests
Build 21979: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2017, 2:34 PM

chad accepted this revision.Apr 17 2017, 2:34 PM

This revision is now accepted and ready to land.Apr 17 2017, 2:34 PM

Harbormaster completed remote builds in B16502: Diff 42568.Apr 17 2017, 2:35 PM

Closed by commit rPb08b4cf0b5ff: Fix a bad variable in global typehaead order/limit code (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2017, 2:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

28 lines

webroot/

rsrc/

js/

core/

behavior-search-typeahead.js

5 lines

Diff 42568

View Options

resources/celerity/map.php