Page MenuHomePhabricator

Fix some minor curtain overflow/wrap issues
ClosedPublic

Authored by epriestley on Apr 10 2017, 10:09 PM.
Tags
None
Referenced Files
F15429817: D17650.id42453.diff
Mon, Mar 24, 4:27 AM
F15400267: D17650.id.diff
Mon, Mar 17, 10:42 AM
F15374429: D17650.id42449.diff
Wed, Mar 12, 6:55 PM
Unknown Object (File)
Feb 21 2025, 9:55 PM
Unknown Object (File)
Feb 9 2025, 3:44 AM
Unknown Object (File)
Feb 9 2025, 3:44 AM
Unknown Object (File)
Feb 9 2025, 3:44 AM
Unknown Object (File)
Jan 24 2025, 8:06 PM
Subscribers
None

Details

Summary

Fixes T12503.

  • Users with creative usernames like MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM could overflow "Subscribers" in the curtain UI.
  • Other content like packages could also overflow.
  • Users with interesting and unique names like WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW who were also away or disabled could get a linebreak between their availability dot and their username.
Test Plan

See T12503 for "before" screenshots. Also tested mobile, which looked fine, but didn't screenshot it.

Screen Shot 2017-04-10 at 3.05.31 PM.png (181×367 px, 12 KB)

Screen Shot 2017-04-10 at 3.06.33 PM.png (648×329 px, 81 KB)

Diff Detail

Repository
rP Phabricator
Branch
wrap1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16378
Build 21784: Run Core Tests
Build 21783: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 10 2017, 10:37 PM
This revision was automatically updated to reflect the committed changes.