Page MenuHomePhabricator

Fix some minor curtain overflow/wrap issues
ClosedPublic

Authored by epriestley on Apr 10 2017, 10:09 PM.
Tags
None
Referenced Files
F14637345: D17650.diff
Fri, Jan 10, 11:00 PM
Unknown Object (File)
Sat, Dec 28, 6:14 PM
Unknown Object (File)
Wed, Dec 18, 3:02 AM
Unknown Object (File)
Tue, Dec 17, 7:37 AM
Unknown Object (File)
Sat, Dec 14, 9:27 AM
Unknown Object (File)
Dec 9 2024, 12:52 PM
Unknown Object (File)
Dec 9 2024, 12:52 PM
Unknown Object (File)
Dec 9 2024, 12:51 PM
Subscribers
None

Details

Summary

Fixes T12503.

  • Users with creative usernames like MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM could overflow "Subscribers" in the curtain UI.
  • Other content like packages could also overflow.
  • Users with interesting and unique names like WWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWWW who were also away or disabled could get a linebreak between their availability dot and their username.
Test Plan

See T12503 for "before" screenshots. Also tested mobile, which looked fine, but didn't screenshot it.

Screen Shot 2017-04-10 at 3.05.31 PM.png (181×367 px, 12 KB)

Screen Shot 2017-04-10 at 3.06.33 PM.png (648×329 px, 81 KB)

Diff Detail

Repository
rP Phabricator
Branch
wrap1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16378
Build 21784: Run Core Tests
Build 21783: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 10 2017, 10:37 PM
This revision was automatically updated to reflect the committed changes.