Page MenuHomePhabricator

Make "arc download" use "file.search" if available
ClosedPublic

Authored by epriestley on Apr 4 2017, 4:53 PM.
Tags
None
Referenced Files
F15582085: D17614.diff
Wed, May 7, 2:51 PM
F15571866: D17614.id42358.diff
Mon, May 5, 11:01 AM
F15541475: D17614.id.diff
Fri, Apr 25, 12:11 PM
F15534890: D17614.diff
Thu, Apr 24, 2:33 AM
F15424681: D17614.id42378.diff
Mar 22 2025, 11:52 PM
F15412676: D17614.diff
Mar 19 2025, 2:19 PM
F15411966: D17614.id42378.diff
Mar 19 2025, 10:33 AM
F15397211: D17614.id42358.diff
Mar 16 2025, 6:49 PM
Subscribers
None

Details

Summary

Fixes T8348. Just use normal HTTP GET to download files if the server is sufficiently modern.

Test Plan

Downloaded various files with --as, --show, large files, small files, old server, new server.

Diff Detail

Repository
rARC Arcanist
Branch
files5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistDownloadWorkflow.php:179XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16285
Build 21646: Run Core Tests
Build 21645: arc lint + arc unit