Page MenuHomePhabricator
Differential D17614

Make "arc download" use "file.search" if available
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 4:53 PM.
Tags
None
Referenced Files
F18649891: D17614.diff
Sat, Sep 20, 10:34 PM
F18630646: D17614.id.diff
Tue, Sep 16, 12:18 PM
F18621637: D17614.id42378.diff
Mon, Sep 15, 9:01 AM
F18592167: D17614.diff
Fri, Sep 12, 11:22 AM
F18566143: D17614.id.diff
Tue, Sep 9, 2:20 PM
F18500810: D17614.diff
Thu, Sep 4, 9:21 PM
F18470237: D17614.id42378.diff
Tue, Sep 2, 5:42 PM
F18470234: D17614.id42378.diff
Tue, Sep 2, 5:41 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8348: `arc download` doesn't support chunked downloads
Commits
rARC82b7cd778a28: Make "arc download" use "file.search" if available
Summary

Fixes T8348. Just use normal HTTP GET to download files if the server is sufficiently modern.

Test Plan

Downloaded various files with --as, --show, large files, small files, old server, new server.

Diff Detail

Repository
rARC Arcanist
Branch
files5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistDownloadWorkflow.php:179XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16285
Build 21646: Run Core Tests
Build 21645: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
workflow/
157 lines

Diff 42358

View Options

src/workflow/ArcanistDownloadWorkflow.php

Loading...
Phabricator · Built by Phacility