Page MenuHomePhabricator
Differential D17520

Add better error checking to 'Add to Dashboard'
ClosedPublic
Actions

Authored by chad on Mar 20 2017, 9:47 PM.
Tags
None
Referenced Files
F14496945: D17520.id42131.diff
Fri, Jan 3, 3:34 PM
Unknown Object (File)
Sun, Dec 22, 6:58 PM
Unknown Object (File)
Sun, Dec 22, 1:07 AM
Unknown Object (File)
Wed, Dec 11, 10:11 AM
Unknown Object (File)
Fri, Dec 6, 12:28 PM
Unknown Object (File)
Nov 19 2024, 12:01 AM
Unknown Object (File)
Nov 10 2024, 11:04 PM
Unknown Object (File)
Nov 8 2024, 6:40 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5307: UX for taking actions with search results
Commits
rP9b07adb8dad3: Add better error checking to 'Add to Dashboard'
Summary

Ref T5307. Adds a better query check query, sets required for the name, adds the correct URI for cancelling.

Test Plan

Test a form without a name, fake a query string, test cancel button.

Diff Detail

Repository
rP Phabricator
Branch
tarnation (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16046
Build 21282: Run Core Tests
Build 21281: arc lint + arc unit

Event Timeline

chad created this revision.Mar 20 2017, 9:47 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 20 2017, 9:47 PM
Harbormaster completed remote builds in B16046: Diff 42131.Mar 20 2017, 9:48 PM
epriestley accepted this revision.Mar 20 2017, 9:52 PM
epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
44

who's a good query

is it you? are you a good query??

pet pet pat yes you're a good query

This revision is now accepted and ready to land.Mar 20 2017, 9:52 PM
chad added a comment.Mar 20 2017, 9:55 PM

I'm not a fan of adding the Dashboard ID to select, but maybe I could just switch to typeahead if you have more than n dashboards. I just want to solve a real problem not a test data problem. Will see what happens when I use it on this install. :)

Closed by commit rP9b07adb8dad3: Add better error checking to 'Add to Dashboard' (authored by chad, committed by chad). · Explain WhyMar 20 2017, 9:55 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Mar 20 2017, 10:01 PM

404

https://secure.phabricator.com/dashboard/panel/install/DifferentialRevisionSearchEngine/authored/

epriestley added inline comments.Mar 20 2017, 10:06 PM
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
32

Oh, this should be $v_query.

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
controller/
24 lines

Diff 42131

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Loading...
Phabricator · Built by Phacility