Page MenuHomePhabricator
Differential D17520

Add better error checking to 'Add to Dashboard'
ClosedPublic
Actions

Authored by chad on Mar 20 2017, 9:47 PM.
Tags
None
Referenced Files
F18849384: D17520.id42132.diff
Oct 30 2025, 9:31 AM
F18812439: D17520.diff
Oct 20 2025, 9:18 AM
F18809581: D17520.id42132.diff
Oct 19 2025, 3:13 PM
F18755292: D17520.id.diff
Oct 5 2025, 4:47 AM
F18753698: D17520.diff
Oct 4 2025, 8:00 PM
F18728108: D17520.id.diff
Sep 30 2025, 9:06 AM
F18724362: D17520.diff
Sep 30 2025, 3:35 AM
F18701196: D17520.id42131.diff
Sep 27 2025, 5:51 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5307: UX for taking actions with search results
Commits
rP9b07adb8dad3: Add better error checking to 'Add to Dashboard'
Summary

Ref T5307. Adds a better query check query, sets required for the name, adds the correct URI for cancelling.

Test Plan

Test a form without a name, fake a query string, test cancel button.

Diff Detail

Repository
rP Phabricator
Branch
tarnation (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16046
Build 21282: Run Core Tests
Build 21281: arc lint + arc unit

Event Timeline

chad created this revision.Mar 20 2017, 9:47 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 20 2017, 9:47 PM
Harbormaster completed remote builds in B16046: Diff 42131.Mar 20 2017, 9:48 PM
epriestley accepted this revision.Mar 20 2017, 9:52 PM
epriestley added inline comments.
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
44

who's a good query

is it you? are you a good query??

pet pet pat yes you're a good query

This revision is now accepted and ready to land.Mar 20 2017, 9:52 PM
chad added a comment.Mar 20 2017, 9:55 PM

I'm not a fan of adding the Dashboard ID to select, but maybe I could just switch to typeahead if you have more than n dashboards. I just want to solve a real problem not a test data problem. Will see what happens when I use it on this install. :)

Closed by commit rP9b07adb8dad3: Add better error checking to 'Add to Dashboard' (authored by chad, committed by chad). · Explain WhyMar 20 2017, 9:55 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Mar 20 2017, 10:01 PM

404

https://secure.phabricator.com/dashboard/panel/install/DifferentialRevisionSearchEngine/authored/

epriestley added inline comments.Mar 20 2017, 10:06 PM
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
32

Oh, this should be $v_query.

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
controller/
24 lines

Diff 42131

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Loading...
Phabricator · Built by Phacility