Page MenuHomePhabricator

Store "last comment" and "last action" diffs on reviewers
ClosedPublic

Authored by epriestley on Mar 20 2017, 5:01 PM.
Tags
None
Referenced Files
F18459137: D17514.id.diff
Mon, Sep 1, 4:21 PM
F18422171: D17514.diff
Sat, Aug 30, 5:48 PM
F18094471: D17514.diff
Aug 7 2025, 10:09 PM
F18081076: D17514.id42139.diff
Aug 4 2025, 10:34 PM
F18061961: D17514.id42123.diff
Aug 4 2025, 12:27 PM
F17928162: D17514.id.diff
Jul 30 2025, 3:50 PM
F17912108: D17514.diff
Jul 29 2025, 3:49 PM
F17835798: D17514.id.diff
Jul 26 2025, 3:38 PM
Subscribers
None

Details

Summary

Ref T10967. We have a "commented" state to help reviewers get a better sense of who is part of a discussion, and a "last action" state to help distinguish between "accept" and "accepted an older version", for the purposes of sticky accepts and as a UI hint.

Currently, these are first-class states, partly beacuse we were somewhat limited in what we could do with edges. However, a more flexible way to represent them is as flags separate from the primary state flag.

In the new storage, write them as separate state information: lastActionDiffPHID stores the Diff PHID of the last review action (accept, reject, etc). lastCommentDiffPHID stores the Diff PHID of the last comment (top-level or inline).

Test Plan

Applied storage changes, commented and acted on a revision. Saw appropriate state reflected in the database.

Diff Detail

Repository
rP Phabricator
Branch
rev4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16038
Build 21267: Run Core Tests
Build 21266: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.