Page MenuHomePhabricator

Store "last comment" and "last action" diffs on reviewers
ClosedPublic

Authored by epriestley on Mar 20 2017, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 4:41 PM
Unknown Object (File)
Tue, Mar 12, 10:33 PM
Unknown Object (File)
Feb 17 2024, 4:16 AM
Unknown Object (File)
Jan 23 2024, 5:20 AM
Unknown Object (File)
Dec 27 2023, 10:01 PM
Unknown Object (File)
Dec 27 2023, 10:15 AM
Unknown Object (File)
Dec 21 2023, 5:00 PM
Unknown Object (File)
Dec 13 2023, 12:44 AM
Subscribers
None

Details

Summary

Ref T10967. We have a "commented" state to help reviewers get a better sense of who is part of a discussion, and a "last action" state to help distinguish between "accept" and "accepted an older version", for the purposes of sticky accepts and as a UI hint.

Currently, these are first-class states, partly beacuse we were somewhat limited in what we could do with edges. However, a more flexible way to represent them is as flags separate from the primary state flag.

In the new storage, write them as separate state information: lastActionDiffPHID stores the Diff PHID of the last review action (accept, reject, etc). lastCommentDiffPHID stores the Diff PHID of the last comment (top-level or inline).

Test Plan

Applied storage changes, commented and acted on a revision. Saw appropriate state reflected in the database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.