Page MenuHomePhabricator

Store "last comment" and "last action" diffs on reviewers
ClosedPublic

Authored by epriestley on Mar 20 2017, 5:01 PM.
Tags
None
Referenced Files
F17835798: D17514.id.diff
Sat, Jul 26, 3:38 PM
F17828463: D17514.id42139.diff
Sat, Jul 26, 9:13 AM
F17807555: D17514.diff
Fri, Jul 25, 3:02 PM
F17759894: D17514.id42139.diff
Tue, Jul 22, 6:56 PM
F17757125: D17514.id42123.diff
Tue, Jul 22, 3:39 PM
F17738202: D17514.diff
Sun, Jul 20, 11:06 PM
Unknown Object (File)
Jun 28 2025, 3:27 PM
Unknown Object (File)
Jun 17 2025, 8:30 AM
Subscribers
None

Details

Summary

Ref T10967. We have a "commented" state to help reviewers get a better sense of who is part of a discussion, and a "last action" state to help distinguish between "accept" and "accepted an older version", for the purposes of sticky accepts and as a UI hint.

Currently, these are first-class states, partly beacuse we were somewhat limited in what we could do with edges. However, a more flexible way to represent them is as flags separate from the primary state flag.

In the new storage, write them as separate state information: lastActionDiffPHID stores the Diff PHID of the last review action (accept, reject, etc). lastCommentDiffPHID stores the Diff PHID of the last comment (top-level or inline).

Test Plan

Applied storage changes, commented and acted on a revision. Saw appropriate state reflected in the database.

Diff Detail

Repository
rP Phabricator
Branch
rev4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16038
Build 21267: Run Core Tests
Build 21266: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.