Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"
ClosedPublic

Authored by epriestley on Mar 19 2017, 12:32 AM.
Tags
None
Referenced Files
F19096756: D17508.diff
Thu, Dec 4, 10:58 AM
F18843290: D17508.diff
Oct 28 2025, 9:13 PM
F18774198: D17508.diff
Oct 9 2025, 3:49 PM
F18764562: D17508.id42113.diff
Oct 7 2025, 6:37 AM
F18733508: D17508.id.diff
Sep 30 2025, 10:36 PM
F18732651: D17508.diff
Sep 30 2025, 7:11 PM
F18732636: D17508.diff
Sep 30 2025, 7:06 PM
F18732620: D17508.diff
Sep 30 2025, 7:02 PM
Subscribers
None

Details

Summary

Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable