Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"
ClosedPublic

Authored by epriestley on Mar 19 2017, 12:32 AM.
Tags
None
Referenced Files
F14414814: D17508.id42113.diff
Tue, Dec 24, 4:15 PM
F14407585: D17508.diff
Tue, Dec 24, 3:20 AM
Unknown Object (File)
Fri, Dec 13, 5:16 AM
Unknown Object (File)
Mon, Dec 9, 3:24 PM
Unknown Object (File)
Sat, Dec 7, 8:58 PM
Unknown Object (File)
Fri, Dec 6, 5:31 PM
Unknown Object (File)
Thu, Dec 5, 12:07 PM
Unknown Object (File)
Thu, Dec 5, 10:45 AM
Subscribers
None

Details

Summary

Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable