Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"
ClosedPublic

Authored by epriestley on Mar 19 2017, 12:32 AM.
Tags
None
Referenced Files
F15517528: D17508.id42113.diff
Sat, Apr 19, 3:35 AM
F15493050: D17508.id42114.diff
Sat, Apr 12, 9:04 PM
F15492774: D17508.id42113.diff
Sat, Apr 12, 6:10 PM
F15491329: D17508.id42114.diff
Sat, Apr 12, 2:03 AM
F15490454: D17508.id.diff
Fri, Apr 11, 5:35 PM
F15487550: D17508.diff
Thu, Apr 10, 3:06 PM
F15403759: D17508.id42114.diff
Mar 18 2025, 4:42 AM
F15397272: D17508.diff
Mar 16 2025, 7:16 PM
Subscribers
None

Details

Summary

Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable