Differential D17456

Add more icon choices to Badges
ClosedPublic
Actions

Authored by chad on Mar 3 2017, 9:31 PM.

Tags

None

Referenced Files

	F13235748: D17456.id41978.diff
	Tue, May 21, 6:21 AM

	F13209902: D17456.diff
	Fri, May 17, 2:48 AM

	F13202972: D17456.diff
	Tue, May 14, 11:22 PM

	F13202087: D17456.id.diff
	Tue, May 14, 9:35 PM

	F13201683: D17456.diff
	Tue, May 14, 2:34 PM

	F13185252: D17456.diff
	Sat, May 11, 2:43 AM

	F13176937: D17456.id.diff
	Wed, May 8, 6:12 PM

	Unknown Object (File)
	Tue, May 7, 1:43 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9010: Allow badges to have any Font Awesome icon
T9006: Allow users to pick which Badges show on Timeline

Commits

rP1460f2b85ca8: Add more icon choices to Badges

Summary

Ref T9010. This adds more icons and lets the IconChooser handle more icons more easier.

Test Plan

Test Project Icons, Badges Icons

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 3 2017, 9:31 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 3 2017, 9:31 PM

Harbormaster completed remote builds in B15882: Diff 41978.Mar 3 2017, 9:32 PM

Actual task ref is T9010?

src/applications/files/controller/PhabricatorFileIconSetSelectController.php
34	This should work correctly for all cases we have now, but I think it does some slightly odd stuff for numbers like 24, which I believe it will lay out as: XXXXX XXXXX XXXXX XXXXX XXXX If we eventually let users customize this or hit weird cases, we could start with this breakpoint and then search nearby values for one that divides the count evenly, so this would end up as 4x6.

This revision is now accepted and ready to land.Mar 3 2017, 9:37 PM

I have some plans to allow any IconSet to be extended, so I'll get the edge cases then.

Specifically, it still centers the icons, so off-number should still render OK

Closed by commit rP1460f2b85ca8: Add more icon choices to Badges (authored by chad, committed by chad). · Explain WhyMar 3 2017, 9:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

icon/

PhabricatorBadgesIconSet.php

18 lines

files/

controller/

PhabricatorFileIconSetSelectController.php

3 lines

Diff 41982

src/applications/badges/icon/PhabricatorBadgesIconSet.php

Loading...

src/applications/files/controller/PhabricatorFileIconSetSelectController.php

Loading...